X-LightYear opened a new pull request, #4988:
URL: https://github.com/apache/rocketmq-dashboard/pull/4988

   ## Summary
   
   - preserve `regionName` and `resourceCountsAvailable` in instance update 
responses
   - keep the update response consistent with the instance inventory 
representation
   - add deterministic regression coverage for both fields
   
   ## Root cause
   
   `InstanceService.updateInstance` creates the saved response from 
`copyOf(existing)`,
   but `copyOf` did not copy the list-only fields `regionName` and
   `resourceCountsAvailable`. The builder therefore returned `regionName=null` 
and
   the default availability value after an otherwise unrelated update.
   
   ## Fix
   
   Copy both existing response fields when creating the update entity. No 
persisted
   instance fields or update semantics are changed.
   
   ## Testing
   
   - 
`InstanceServiceTest#updateInstanceShouldPreserveListOnlyFieldsInResponse`: 
passed
   - `InstanceServiceTest`: 90 passed
   - Maven Checkstyle: 0 violations
   - `mvn -Dmaven.compiler.proc=full -DskipTests package`: passed
   
   Fixes #4987
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to