X-LightYear opened a new pull request, #4991: URL: https://github.com/apache/rocketmq-dashboard/pull/4991
## Summary - allow instance-scoped metrics queries to select a sole globally available data source - preserve dedicated-source precedence and ambiguity checks - add regression coverage for empty and null global bindings ## Root cause `MetricsService.queryInstance` only considered data sources whose `instanceIds` explicitly contained the requested instance. This bypassed the existing contract that a data source with no instance bindings is globally available. ## Fix Treat null or empty `instanceIds` as globally available during instance-scoped source selection. Dedicated instance-bound sources still take precedence; multiple eligible shared/global sources still return the existing conflict response. ## Testing - `MetricsServiceTest` and `MetricsControllerTest`: 39 passed - focused global-binding regressions: 2 passed - Checkstyle: 0 violations - `mvn -Dmaven.compiler.proc=full -DskipTests package`: passed The frontend lint/build gate could not run in the audit worktree because its `node_modules` directory is not installed; the change is backend-only. Fixes #4990 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
