X-LightYear opened a new pull request, #4993: URL: https://github.com/apache/rocketmq-dashboard/pull/4993
## Summary - implement Apache instance-scoped cluster discovery in `RealClusterProvider` - resolve the selected instance through the existing runtime admin client resolver - add deterministic regression coverage for selected-instance cluster discovery ## Root cause `ClusterService.listClusters(instanceId)` delegates to `ClusterProvider.discoverClusters(instanceId)`. `RealClusterProvider` inherited the default SPI implementation, which returns an empty list for every non-blank instance ID. ## Fix Use `RuntimeAdminClientResolver` to resolve the selected instance and query its broker cluster information, while preserving the existing unscoped discovery path. ## Testing - `RealClusterProviderTest#discoverClustersForSelectedInstanceShouldReturnItsClusters`: passed - `RealClusterProviderTest,ClusterServiceTest`: 53 passed - `mvn -Dmaven.compiler.proc=full -DskipTests package`: passed, Checkstyle 0 violations The regression test failed before the fix with an empty cluster list. Fixes #4992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
