X-LightYear opened a new pull request, #4997:
URL: https://github.com/apache/rocketmq-dashboard/pull/4997

   ## Summary
   
   - ignore stale maintenance-window pagination responses
   - keep the selected page when requests complete out of order
   - add deterministic deferred-Promise regression coverage
   
   ## Root cause
   
   SystemAlertsPage.loadSilences applied every response directly to the 
maintenance-window list and current page. If a user changed pages before the 
earlier request completed, the older response could overwrite the newer page.
   
   ## Fix
   
   Track the latest maintenance-window request generation and only allow the 
current request to update rows, totals, current page, loading state, or surface 
an error.
   
   ## Testing
   
   - focused regression: src/pages/ops/__tests__/SystemAlertsPage.test.tsx -t 
newest
   - full SystemAlertsPage.test.tsx: 18 passed
   - relevant ESLint: 0 errors, 1 pre-existing warning
   - npm run build: passed
   
   Fixes #4996


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to