X-LightYear opened a new pull request, #5009: URL: https://github.com/apache/rocketmq-dashboard/pull/5009
## Summary - align `rmq.instance.metrics` catalog input schema with raw and semantic query support - require `step` before requests reach `MetricsService` - add parsed-schema regression coverage for valid and invalid forms ## Root cause The catalog still required `metric` after semantic profile selection was added to `MetricQueryDTO` and `MetricsService`, and omitted `step` even though `MetricsService` requires it. ## Fix Publish mutually exclusive raw `metric` or `profileId` + `semanticMetric` forms and require `instanceId`, `start`, `end`, and `step`. No Java runtime query behavior changed. ## Testing - `mvn -q -Dmaven.compiler.proc=full -Dtest=ToolCatalogTest#exposesAllSupportedInstanceMetricsQueryFormsInItsInputContract test` — passed - `mvn -q -Dmaven.compiler.proc=full -Dtest=ToolCatalogTest,ToolOutputSchemaContractTest,MetricsServiceTest test` — passed - `mvn -q -Dmaven.compiler.proc=full -DskipTests checkstyle:check` — passed - `mvn -q -Dmaven.compiler.proc=full -DskipTests package` — passed - full `mvn test` was attempted; unrelated failures remain in this Windows environment because local MySQL credentials are unavailable and `sh`/`cat` are not installed Fixes #5008 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
