unbridled-41 commented on PR #5001: URL: https://github.com/apache/rocketmq-dashboard/pull/5001#issuecomment-5788085043
Verification pass (from a clean checkout of `9dd13c72`, not restated from the description): **Citations re-verified against base `1ef5d860` with `grep -n`/`sed -n`:** - `ProducerController.java:37-43` (base) — `listProducerGroups` declares `@RequestParam(required = false) String topic` and passes it down. - `Producer.tsx:187-191` (base) — the page always sends `topic: selectedTopic` (with `query`, `limit: PRODUCER_GROUP_SELECTOR_LIMIT`), so production always exercised the dropped parameter. - `RocketMQClientProvider.java:114-116` (base) is exactly `return scanProducerGroups(adminExt, query, limit).groups();` — `topic` never read; `scanProducerGroups` starts at `:118` and only iterates `getAllProducerInfo(brokerAddress)` (`:127-135`). `ProducerTableInfo` (rocketmq-remoting 5.5.1, `remoting.protocol.body`) carries `Map<String, List<ProducerInfo>>` keyed by group — no topic dimension exists in the scan. - The fix's per-group verification reuses `findProducerConnectionsForGroup` (`examineProducerConnectionInfo(group, topic)`), the same call the follow-up connection query makes; its `MQClientException` mapping for not-found/group-absent (base `:198-204`) is what makes a missing connection an empty outcome rather than an error. **Commands re-executed from the clean worktree (empty `server/target`):** - `mvn -o -Dtest='RocketMQClientProviderTest,ProducerConnectionServiceTest,ProviderStubContractTest' test` → surefire XML: RocketMQClientProviderTest `tests="32" failures="0" errors="0"`, ProducerConnectionServiceTest `tests="8" failures="0" errors="0"`, ProviderStubContractTest `tests="11" failures="0" errors="0"`. No commit added; verification comment only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
