unbridled-41 commented on PR #5000:
URL:
https://github.com/apache/rocketmq-dashboard/pull/5000#issuecomment-5788080049
Verification pass (from a clean checkout of `0882b10a`, not restated from
the description):
**Citations re-verified against base `1ef5d860` with `grep -n`/`sed -n`:**
- `SettingsService.java:130` (base) is `saveGeneralSettings`; the method
body contains **zero** occurrences of `dingtalkWebhook`/`smsWebhook` (grep over
the base method body: 0) — the marker reached
`settingsRepository.saveGeneralSettings` verbatim. The redaction it must
round-trip against is `:112-127` (`currentUserIsAdminOrSystem` check at `:109`,
`REDACTED_NOTIFICATION_WEBHOOK = "******"` at `:61`).
- Console echo confirmed at `GeneralSettingsTab.tsx:54`/`:58` (base
`buildPayload`) and the pre-save re-read through `loadFreshSettings` at
`:104`/`:120-121`/`:134`; the notification form is pre-filled with the redacted
value at `:83-88` (`notifyForm.setFieldsValue({ dingtalkWebhook:
loaded.dingtalkWebhook, ... })`), so even a manual save path submits the marker.
- Branch `:148-154` adds the two restoration branches;
`REDACTED_NOTIFICATION_WEBHOOK` was widened from `private` to package-visible
so the test compares against the same constant the service writes (no literal
drift).
**Admin-path parity (stated in the description, re-checked here):** an admin
GET returns the stored value unredacted (`:109-111`), so an admin save never
equals the marker and never enters the new branches — the fix only changes what
happens to reader-session saves.
**Commands re-executed from the clean worktree (empty `server/target`):**
- `mvn -o -Dtest='SettingsServiceTest,SettingsControllerTest' test` →
surefire XML: SettingsServiceTest `tests="45" failures="0" errors="0"`,
SettingsControllerTest `tests="23" failures="0" errors="0"`.
No commit added; verification comment only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
