X-LightYear opened a new pull request, #5015: URL: https://github.com/apache/rocketmq-dashboard/pull/5015
## Summary - expose persisted system alert events through `rmq.alert.system.list` - expose notification delivery diagnostics through `rmq.alert.delivery.list` - add deterministic handler and catalog/output-contract coverage ## Significance This is a MEDIUM cross-layer feature completion: the backend, REST API, and Studio UI already expose alert incidents and delivery failures, but MCP diagnostics could only list alert rules. The change reuses the existing services and adds read-only MCP contracts without new persistence, provider, or authentication behavior. ## Existing capability reused - `AlertService.listAlerts(...)` and its existing filter/pagination semantics - `NotificationOutboxService.listDeliveries(...)` and its existing delivery status filters - existing platform-level MCP catalog, handler, pagination, and output-schema conventions ## Before / after flow Before: `MCP planner -> alert rule list only` `REST/UI -> system alerts and notification deliveries` After: `MCP planner -> rmq.alert.system.list -> AlertService.listAlerts -> persisted system alerts` `MCP planner -> rmq.alert.delivery.list -> NotificationOutboxService.listDeliveries -> persisted delivery diagnostics` Both tools remain read-only and use `alert:read`. Acknowledge, clear, and retry mutations are intentionally out of scope. ## Issue Closes #5014 ## Testing - `mvn -q '-Dmaven.compiler.proc=full' '-Dtest=SystemAlertListToolHandlerTest,NotificationDeliveryListToolHandlerTest,ToolCatalogTest,ToolOutputSchemaContractTest' test` — passed - `mvn -q '-Dmaven.compiler.proc=full' '-Dtest=ToolCatalogTest,ToolOutputSchemaContractTest,ToolDiscoveryServiceTest,ToolInstanceBindingTest,AlertRuleListToolHandlerTest,AuditListToolHandlerTest,SystemAlertListToolHandlerTest,NotificationDeliveryListToolHandlerTest' test` — passed - `mvn -q '-Dmaven.compiler.proc=full' '-Dtest=AlertServiceTest,NotificationOutboxServiceTest,SystemAlertControllerTest' test` — passed - `mvn -q '-Dmaven.compiler.proc=full' '-DskipTests' 'checkstyle:check'` — passed - `mvn -q '-Dmaven.compiler.proc=full' '-Dmaven.antrun.skip=true' '-DskipTests' package` — passed - full server suite: 3196 tests, 7 failures and 26 errors caused by the existing local MySQL root-authentication and Windows missing `sh`/`cat` environment; targeted and relevant tests pass The delivery contract deliberately omits `messageContent`; the regression test verifies that the serialized MCP output does not expose it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
