yyqdbngt commented on PR #4685: URL: https://github.com/apache/rocketmq-dashboard/pull/4685#issuecomment-5791108062
Closing this as superseded by #4693 (`02d81ec2`), which is now in `rocketmq-studio` and fixes the same defect, more completely. What the trunk carries after that merge, in the files this pull request touches: - `ClaudeCodeAgentProvider.throwIfTheResumeSessionWasLost` with `ResumeRecovery.RESUME_LOST_CODE`: the provider reports a `--resume` session that no longer exists as its own error code. - `ClaudeCodeStreamParser.resultSubtype()`: the signal is read from the terminal frame, not only from stderr. - `AiConversationRepository.clearRuntimeSessionId` and its MyBatis-Plus implementation: the stale id is nulled by an explicit assignment, because `updateById` skips null entity fields and a fake pass through the ordinary update would be a silent no-op. - `AiRunExecutor.streamWithLostResumeRetry`: the dead id is forgotten, then the turn is retried exactly once without `--resume`, with a `ProviderNotice` to the timeline and the prompt prepared once, outside the retry. So the mechanism this pull request proposed - detect, forget, retry - is all in the trunk, and the retry half is more complete than this branch: this branch never grew the retry path, so today it would only remove working code if it were merged. The remaining difference is shape, not behaviour: here `clearRuntimeSessionId` returns the number of updated rows instead of `void`, and `isLostResumeSubtype` is a named public method instead of an inline comparison. Neither is worth a pull request of its own against code that has just landed; if the row count or the named predicate is ever wanted, it belongs in a follow-up against the merged code rather than in this stale branch. Checked before closing: `git merge-base --is-ancestor 02d81ec2 upstream/rocketmq-studio` exits 0, and all four symbols above are present in the trunk's copies of those files. Nothing in this branch is lost by closing it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
