zmuxuny opened a new pull request, #5019:
URL: https://github.com/apache/rocketmq-dashboard/pull/5019

   ### Which Issue(s) This PR Fixes
   
   - Fixes #5018
   
   ### Brief Description
   
   The license manifest was hashing the entry chunk during `generateBundle`, 
before the final build pipeline rewrote it. The resulting `dist/` failed its 
own post-build license check, including in the frontend Docker image build.
   
   Refresh the manifest's output checksums in `writeBundle` from the files 
actually written to disk. The test simulates a later chunk rewrite, then 
verifies the final manifest passes while a subsequent file modification still 
fails the tamper gate.
   
   ### How Did You Test This Change?
   
   - `cd web && npm run license:test` — 4 passed.
   - `cd web && npm run build` — succeeded; license check passed for 133 
components and 140 license files. The same command failed on the unmodified 
base with `build artifact verification failed: assets/index-*.js`.
   - `docker build -t rocketmq-studio-web:license-check ./web` — succeeded with 
a clean Docker credential config. The same Docker build failed at `npm run 
build` on the unmodified base.
   - `cd web && npm run lint` — 0 errors, 11 existing warnings.
   - `git diff --check` — passed.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits
   - [x] Tests added or updated for non-trivial changes
   - [x] New source files carry the ASF license header (no new source files)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to