zmuxuny opened a new pull request, #5032:
URL: https://github.com/apache/rocketmq-dashboard/pull/5032

   ### Which Issue(s) This PR Fixes
   
   - Fixes #5031
   
   ### Brief Description
   
   A broker configuration update can apply to only some Brokers and return 
`PARTIAL`. The configuration modal stays open, but its old preview remained 
visible, even though the cluster had changed. A preview response still in 
flight could repopulate the panel after the update.
   
   Invalidate the preview request and clear the panel when the operator submits 
a write. A fresh preview is then required to inspect the post-update cluster 
state before retrying. This covers both an already rendered preview and a late 
response without changing the update API or the existing partial-result 
handling.
   
   ### How Did You Test This Change?
   
   - New controlled `PARTIAL`-response test failed on the base branch: the 
modal still contained `defaultTopicQueueNums=8` after the update. It passes 
with the fix and also checks that a late preview response cannot repopulate the 
panel.
   - `cd web && npx vitest run 
src/pages/cluster/__tests__/ClusterPage.test.tsx` — 30 passed.
   - `cd web && npx tsc -b --pretty false` — passed.
   - `cd web && npx eslint src/pages/cluster/index.tsx 
src/pages/cluster/__tests__/ClusterPage.test.tsx` — passed.
   - `cd web && npm run build` — TypeScript and Vite build passed; the existing 
final-artifact license check failed on `assets/index-CjMPr03_.js` (tracked 
separately in #5018 / #5019).
   - `git diff --check` — passed.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in.
   - [x] Commit subject follows Conventional Commits.
   - [x] Regression test covers the partial-write outcome and late preview 
response.
   - [x] No new UI text, source files, or API surface.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to