zmuxuny opened a new pull request, #5034: URL: https://github.com/apache/rocketmq-dashboard/pull/5034
### Which Issue(s) This PR Fixes - Fixes #3558 ### Brief Description Incident responders can now narrow Notification Deliveries by alert title or delivery error and by delivery creation time, alongside the existing channel, status, and instance filters. Search is case-insensitive and treats `%` and `_` literally. The page and count queries use identical predicates, and an inverted time range returns HTTP 400. The picker converts the operator's local times to the UTC values stored by Studio; changing a filter returns to page 1. The earlier attempt #3753 was closed after its base branch was deleted and was not merged. This PR implements the still-open issue on the current `rocketmq-studio` branch and adds a MySQL integration test for the actual query semantics. ### How Did You Test This Change? - `cd server && mvn -B -ntp -Dtest=NotificationOutboxServiceTest,SystemAlertControllerTest,NotificationOutboxMapperIntegrationTest test` — 42 tests passed against MySQL 8, including inclusive time bounds, title/error matching, literal `%`/`_`, count/page consistency, and HTTP 400 handling. - `cd web && npm test -- --run src/pages/ops/__tests__/NotificationDeliveriesPage.test.tsx` — 6 tests passed, including page reset and local-time-to-UTC forwarding. - `cd web && npx tsc -b --pretty false` — passed. - `cd web && npx eslint src/pages/ops/notificationDeliveries.tsx src/pages/ops/__tests__/NotificationDeliveriesPage.test.tsx src/api/ops.ts src/i18n/translations.ts` — passed. - `cd web && npx vite build` — passed. - `git diff --check` — passed. `npm run build` completed TypeScript and Vite but failed at the existing final-artifact license gate tracked in #5018; #5019 addresses that separately. Backend CI's MySQL setup is separately addressed in #5029. ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Commit subject follows Conventional Commits - [x] Tests added or updated for non-trivial changes, test methods named `...Test` - [x] New UI text has both Chinese and English entries under `web/src/i18n/` - [x] No architecture boundaries changed - [x] No new source files require ASF license headers - [x] Alerting documentation explains the new filters and time semantics -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
