zmuxuny opened a new pull request, #5042: URL: https://github.com/apache/rocketmq-dashboard/pull/5042
### Which Issue(s) This PR Fixes - Fixes #5039. ### Brief Description The K8s certificate inventory derives `notBefore` and `notAfter` from an uploaded PEM, but its status calculation only checked expiry. A certificate that becomes valid tomorrow was shown with a green `valid` tag today. Add `not_yet_valid` when `notBefore` is in the future and the certificate has not expired, render it explicitly in the inventory, and document the API value. An already-expired certificate remains `expired`; the existing expiring/valid boundary is unchanged. ### How Did You Test This Change? - Added a fixed-clock service regression: a future-dated certificate failed as `valid` before the fix and now returns `not_yet_valid`, while the persisted source object is not mutated. - Added a page regression for the new status label. It failed before the UI change and passes now. - `cd server && mvn -B -ntp -Dtest=K8sCertServiceTest,K8sCertControllerTest test`: 32 passed; Checkstyle passed. - `cd web && npx vitest run src/pages/cluster/__tests__/K8sCertsPage.test.tsx`: 8 passed. - `cd web && npx tsc -b --pretty false` and touched-file ESLint: passed. - `git diff --check`: passed. Full CI currently cannot start on this branch because the base workflow uses unapproved Docker Action tag references; #5020 addresses that separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
