zmuxuny opened a new pull request, #5060: URL: https://github.com/apache/rocketmq-dashboard/pull/5060
### Which Issue(s) This PR Fixes - Fixes #5059 ### Brief Description - Keep the request ownership check at the point where Proxy nodes, counts, and the stored address are committed. It now runs whether the optional topology/health request succeeds or fails. - Add a controlled regression: an older refresh has received the old address list, its health probe is pending, a newer refresh commits a different list, then the older probe fails. The older response must not restore the old node or address. This closes the failure path left outside the existing out-of-order home-response coverage from #1336. The health probe remains best-effort for the current request; no API or backend behavior changes. ### How Did You Test This Change? - Red/green: the new `Proxy.test.tsx` case failed on the base branch because the newer node disappeared after the older health probe rejected; it passes with this change. - `cd web && npm test -- --run src/pages/studio/__tests__/Proxy.test.tsx`: 16 passed. - `cd web && npx tsc -b --noEmit && npx eslint src/pages/studio/Proxy.tsx src/pages/studio/__tests__/Proxy.test.tsx && npx prettier --check src/pages/studio/Proxy.tsx src/pages/studio/__tests__/Proxy.test.tsx`: passed. - `cd web && npm test`: 1291 passed, 1 failed in the unchanged `ConsumerPage.test.tsx` subscription-check case during the full parallel run. Rerunning that exact case alone passed (1 passed, 35 skipped). This PR does not touch that page or test. - `cd web && npm run build`: TypeScript and Vite completed (8097 modules transformed); the final license artifact check failed on `assets/index-xjQQ9mXf.js`. The existing final-artifact hash fix is tracked separately in #5019. - `git diff --check`: passed. ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Commit subject follows Conventional Commits - [x] Targeted regression test added - [x] No new UI text or source files - [x] No API or documented behavior change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
