Frun1na opened a new pull request, #5087:
URL: https://github.com/apache/rocketmq-dashboard/pull/5087

   ### Which Issue(s) This PR Fixes
   
   - Fixes #<issue-id>
   
   ### Brief Description
   
   The project enforces a 14 px minimum inline font size in review. The main 
layout still carried two 13 px occurrences at tip: the user-avatar fallback 
letter and the user-menu data-mode entry. Both are raised to 14 px.
   
   A new regression test (`MainLayoutFontSize.test.tsx`) renders the layout 
with the real antd tree, opens the user menu, and asserts no element carries an 
inline `13px` font size. It runs against a separate file because 
`MainLayout.test.tsx` replaces the antd dropdown with a mock that does not 
render the reviewed styles.
   
   ### How Did You Test This Change?
   
   ```
   cd web && npx vitest run src/layouts/MainLayoutFontSize.test.tsx
   
   Tests  1 passed (1)
   ```
   
   The test fails on the unpatched layout (one 13 px element found):
   
   ```
   Failed Tests 1
   Tests  1 failed (1)
   ```
   
   `npx eslint` on the touched files reports no issues; `tsc -b` passes.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / 
`refactor:` / `chore:` / `docs:` / `perf:`)
   - [x] Tests added or updated for non-trivial changes, test methods named 
`...Test`
   - [x] New UI text has both Chinese and English entries under `web/src/i18n/`
   - [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit 
checks)
   - [x] New source files carry the ASF license header
   - [ ] Documentation touched where behaviour changed (README / `docs/` / 
in-app help)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to