pilichoumao commented on PR #4771: URL: https://github.com/apache/rocketmq-dashboard/pull/4771#issuecomment-5825887056
Preemptive scope note after the #4769 review, since this PR also touches the catalog surface: I checked #4306's convergence history before asking you to spend review time here. What #4306 removed was `rmq.lite_topic.list` and `rmq.lite_topic.create`, with the recorded rationale "lite topics become topic.list --type LITE". How this PR relates to that decision: - **`rmq.litetopic.session` and `rmq.litetopic.quota` were never in any catalog version** — they are not reinstatements. They expose the session view and the quota watermark that the LiteTopic pages already serve from `LiteTopicService` (session detail with per-topic TTL/Pop progress; current/max topic-session-rate watermark), which no current tool reaches. - **`rmq.litetopic.list` is the one with an overlap claim.** `rmq.topic.list --type LITE` enumerates individual lite topics from topic metadata; this tool returns the pattern-level aggregates the pages render (per pattern: topicCount, consumerCount, totalBacklog, averageTTL, ttlStatus, lastActiveTime, sessionIds) from the same service. If you consider that covered by the flat listing under the converged surface, I'm happy to drop this tool from the PR and keep session + quota only. - `lite_topic.create` is deliberately **not** re-added, consistent with both the convergence and the spec's "creation entry hidden" for LiteTopic. Your call on the shape: keep all three, trim to session + quota, or close if the convergence stands against any lite domain. I won't reopen #4769-style ground either way. Once the scope is settled I'll rebase and regenerate `catalog_gen.go` against the then-current trunk digest in one pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
