lizhimins commented on PR #4801:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4801#issuecomment-5845587253
Thanks for catching this — the correction itself is right:
`.github/PULL_REQUEST_TEMPLATE.md:1` still names `master` as the base, while
`CONTRIBUTING.md:8-9` says every pull request must target `rocketmq-studio`
(same at `:13`, `:92`, `:101`, and `README.md:152`).
We are closing it because the description's check ("this is the only stale
reference") does not hold, and fixing the template alone leaves the issue forms
pointing contributors at the wrong base:
- `.github/ISSUE_TEMPLATE/doc.yml:64` — "Base the branch on `master`"
- `.github/ISSUE_TEMPLATE/enhancement_request.yml:85` — "Pull requests
target the `master` branch"
- `.github/ISSUE_TEMPLATE/feature_request.yml:75` — "the pull request must
target `master`"
- `.github/ISSUE_TEMPLATE/bug_report.yml:135` — "pull requests target the
`master` branch"
- `.github/ISSUE_TEMPLATE/bug_report.yml:36` and `:45` — reproduce on /
report against `master`
Please resubmit this as one change that sweeps all of `.github/`, and
correct two claims in the description: the `README.md` citation is line 152,
not 118; and `master`'s tip is now `chore(studio): 3.0.0 release readiness
(#5007)`, 52 commits behind the trunk at the time of writing, so a pull request
based on `master` silently misses everything merged since — that is the
argument that actually matters here. One coherent pass over the templates is
also what `CONTRIBUTING.md:112-113` asks for. We will merge that version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
