Aias00 commented on PR #4976:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/4976#issuecomment-5846063946

   Addressed the two blocking points from review `5325650060`.
   
   1. I ran the exact timeline query against MySQL 8.0.46. `EXPLAIN 
FORMAT=JSON` reports:
      - `access_type: range`
      - `key: uk_ai_event_conversation_seq`
      - `used_key_parts: [conversation_id, seq]`
      - `using_filesort: false`
   
      Traditional `EXPLAIN` reports `Extra=Using index condition` and no `Using 
filesort`. The full query and relevant plan fragment are now in the PR 
description.
   
   2. I rewrote both the PR and #4974 to state the reachable defect precisely: 
there is no demonstrated production misordered page under the current InnoDB 
plan; the change removes a pagination dependency on unspecified SQL row order 
and makes the ascending contract explicit.
   
   I did not add the optional runtime monotonicity warning. The exact SQL-shape 
test already pins `ORDER BY seq ASC LIMIT`, and scanning/logging every page 
would only detect a violated database contract after the query returned; it 
would not repair the page. No source code changed in this review update.
   
   @lizhimins please re-review when convenient.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to