X-LightYear opened a new pull request, #5115: URL: https://github.com/apache/rocketmq-dashboard/pull/5115
## Summary - allow `rmq.acl.update` to pass provider-specific string identifiers through to the service - preserve numeric Apache ACL updates - add deterministic Tencent role-name regression coverage ## Root cause `AclUpdateToolHandler` parsed every `id` as `Long` before `AclService` could route Tencent instances. Tencent ACL roles are identified by role name, while `AclService` / `TencentAclService` already support that identifier. ## Fix Keep numeric identifiers as `Long` and defer non-numeric identifiers to `AclService`, where provider-specific validation and handling occurs. Blank identifiers remain rejected. ## Testing - pre-fix deterministic test failed with `ACL id must be numeric: role-orders` - focused ACL/MCP suite: 127 passed - full server test: 3237 tests run; 7 failures and 26 errors from integration tests unable to authenticate to the local MySQL instance - compile and Checkstyle passed - package reached the binary-license gate; the repository's configured `python3` executable is unavailable in this Windows environment Fixes #5114 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
