X-LightYear opened a new pull request, #5132: URL: https://github.com/apache/rocketmq-dashboard/pull/5132
## Summary - quote the metric snapshot `value` column for MyBatis-Plus generated SQL - add deterministic H2 dev-profile coverage for batch save and read ## Root cause `RmqMetricSnapshot.value` had no explicit column mapping. MyBatis-Plus therefore generated an unquoted `value` identifier, which H2 2.4.240 rejects as a reserved keyword while persisting native metric snapshots. ## Fix Map only the `value` field to the existing quoted schema column with `@TableField(`value`)`. This leaves metric collection, repository behavior, and the shared schema unchanged. ## Testing - pre-fix: `MetricSnapshotPersistenceIntegrationTest` failed with `JdbcSQLSyntaxErrorException [42001-240]` at `INSERT ... value ...` - post-fix: `MetricSnapshotPersistenceIntegrationTest`: 1 passed - `CollectorSchedulerTest`: 12 passed - `MybatisPlusMetricSnapshotRepositoryTest`: 2 passed - Checkstyle: 0 violations - `git diff --check`: passed - Java 23 compile and Spring Boot repackage: completed - package binary-license gate: isolated environment failure because `python3` is unavailable (`exec returned: 9009`) Fixes #5131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
