Loyal-Young opened a new pull request, #11271: URL: https://github.com/apache/rocketmq/pull/11271
### Which Issue(s) This PR Fixes - Fixes #11270. ### Brief Description AbstractStartAndShutdown.shutdown/preShutdown abort at the first target exception, leaving earlier registered resources active. This affects composite service cleanup even though reverse-order shutdown is intended. Continue invoking every target in reverse registration order and rethrow the first failure with subsequent distinct failures suppressed. Startup behavior is unchanged. Reproduction: Register three targets, make the last and first throw, and verify the middle target is still cleaned up and both failures are reported. This is an independent bug fix based on develop `78b96bc5e21216cd7896efae08f90c5cde4cae53`, not stacked on the other contributions. It changes one implementation and adds one regression test file; no new protocol or public API is introduced. ### How Did You Test This Change? - The bug-specific regression fails against the unmodified implementation. - On this independent branch, JDK 8 / Maven 3.9.9: `AbstractStartAndShutdownFailureTest` — 2 tests passed, zero failures/errors/skips. - Command: `mvn -pl common -am -Dspotbugs.skip=true -Djacoco.skip=true -Dsurefire.failIfNoSpecifiedTests=false -Dtest=AbstractStartAndShutdownFailureTest test`. - The combined candidate changes also pass the complete common-module suite: 284 tests, zero failures/errors/skips. - Maven Checkstyle passed; `git diff --check` passed. Local runs disable JaCoCo and SpotBugs; this does not claim that upstream GitHub Actions have run or passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
