Loyal-Young opened a new pull request, #11267:
URL: https://github.com/apache/rocketmq/pull/11267

   ### Which Issue(s) This PR Fixes
   
   - Fixes #11266.
   
   ### Brief Description
   
   ExceptionUtils.getRealException unwraps only one 
CompletionException/ExecutionException layer. Mixed nested wrappers leave a 
wrapper rather than the domain exception, so proxy response builders can fall 
back to an internal error instead of the correct domain response.
   
   Unwrap consecutive future wrappers until a non-wrapper or a cause-less 
wrapper is reached, without unwrapping domain exceptions or looping on cyclic 
causes.
   
   Reproduction: Wrap an IllegalArgumentException in CompletionException -> 
ExecutionException -> CompletionException and inspect getRealException's result.
   
   This is an independent bug fix based on develop 
`78b96bc5e21216cd7896efae08f90c5cde4cae53`, not stacked on the other 
contributions. It changes one implementation and adds one regression test file; 
no new protocol or public API is introduced.
   
   ### How Did You Test This Change?
   
   - The bug-specific regression fails against the unmodified implementation.
   - On this independent branch, JDK 8 / Maven 3.9.9: 
`ExceptionUtilsNestedTest` — 4 tests passed, zero failures/errors/skips.
   - Command: `mvn -pl common -am -Dspotbugs.skip=true -Djacoco.skip=true 
-Dsurefire.failIfNoSpecifiedTests=false -Dtest=ExceptionUtilsNestedTest test`.
   - The combined candidate changes also pass the complete common-module suite: 
284 tests, zero failures/errors/skips.
   - Maven Checkstyle passed; `git diff --check` passed. Local runs disable 
JaCoCo and SpotBugs; this does not claim that upstream GitHub Actions have run 
or passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to