coder999o opened a new pull request, #5140: URL: https://github.com/apache/rocketmq-dashboard/pull/5140
## What is the purpose of the change Cloud availability samples include `cloudStatus` in their labels. Hashing that changing status into the alert fingerprint creates a new incident when an unavailable instance moves from `STOPPED` to `STARTING`, and can incorrectly resolve the previous incident. ## Brief changelog - Exclude the descriptive `cloudStatus` label from alert identity while retaining it in event labels. - Keep `cloudInstanceId` in the fingerprint so different instances remain distinct. - Cover repeated unavailable states, reconciliation, and recovery to `RUNNING`. Existing active alerts retain their old fingerprints, so the first collection after upgrade may produce a one-time incident transition; this change does not migrate stored alert state. ## Verifying this change - `cd server && mvn -q -Dtest=NativeAlertProcessorTest,AlertFingerprintTest,CloudRocketMqClusterMetricsCollectorTest test` (31 passed) - `cd server && mvn -q -DskipTests checkstyle:check` (passed) - `git diff --check` (passed) - `cd server && mvn -q test` (3290 run, 0 failures, 17 integration-test errors; inspected reports show MySQL connection failures) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
