Wang1rrr opened a new pull request, #5143:
URL: https://github.com/apache/rocketmq-dashboard/pull/5143

   Stored cloud-message query results currently replace an unknown queue ID and 
queue offset with `0`, making saved results claim a queue location the provider 
never reported. Preserve those nullable values in the existing snapshot format 
while keeping actual zero and populated offsets unchanged.
   
   The regression test covers snapshot creation and retrieval for null, zero 
and nonzero queue metadata. Additional checks preserve body/property exclusion 
and legacy snapshots with omitted queue fields; existing ownership tests 
continue to pass. No API or schema change is needed. Old snapshots that already 
contain fabricated zero values remain readable, but cannot be repaired reliably.
   
   Fixes #5141
   
   Validation: the new round-trip test failed against the original code 
(`expected null but was 0`), then `mvn -B -ntp 
-Dtest=QueryHistoryServiceTest,QueryHistoryControllerTest test` passed all 18 
tests on Temurin 21 / Maven 3.9.16. `git diff --check` passed. MySQL 
integration tests were not run because this environment has no local MySQL 
service.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to