X-LightYear opened a new issue, #5148:
URL: https://github.com/apache/rocketmq-dashboard/issues/5148

   ## Problem
   
   Proxy config reload failures returned as a non-2xx `ResponseEntity` are not 
recorded as failed operation-audit entries.
   
   ## Reproduction
   
   1. Configure a trusted Proxy endpoint for a cluster.
   2. Make `POST /admin/reloadConfig` return a non-2xx response that is 
returned by `RestTemplate` (for example, a 3xx response with redirect following 
disabled).
   3. Invoke the Studio proxy reload operation.
   4. Inspect the operation audit records.
   
   ## Expected behavior
   
   The reload operation should produce a failed `RELOAD_PROXY_CONFIG` audit 
record, consistently with HTTP status exceptions, transport failures, and 
unexpected failures.
   
   ## Actual behavior
   
   `ProxyAddressService.reloadValidatedProxy` throws a `BusinessException(502)` 
for the non-2xx response. The following `catch (BusinessException)` rethrows it 
without recording the failed audit entry.
   
   ## Root cause
   
   The non-2xx response branch and the `BusinessException` rethrow bypass the 
failure-audit path.
   
   ## Scope
   
   The issue is limited to failure audit observability for proxy config 
reloads. The HTTP response status and API error behavior are otherwise 
unchanged.
   
   ## Regression evidence
   
   A deterministic test using a non-2xx `ResponseEntity` fails on the current 
`rocketmq-studio` base because the expected failed audit record is never 
invoked.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to