chstercc opened a new pull request, #5150:
URL: https://github.com/apache/rocketmq-dashboard/pull/5150
### Which Issue(s) This PR Fixes
- Fixes #5101
### Brief Description
`rmq.group.detail` dropped the topic of each queue in its `progress` block,
so queues
from two topics sharing the same broker and queue id became
indistinguishable. This
adds the queue's `topic` to the `QueueProgress` output record and output
schema, with
a regression test covering the two-topic case.
### How Did You Test This Change?
```text
cd server && mvn -o
-Dtest=ConsumerGroupReadToolHandlersTest,ToolOutputSchemaContractTest test
# Tests run: 7, Failures: 0, Errors: 0
cd server && mvn -o test
# Tests run: 3288, Failures: 0, Errors: 19, Skipped: 4
# The remaining errors are integration/context tests requiring MySQL 8 or
external
# services (StudioApplicationTest, *IntegrationTest,
ClaudeCodeAgentProviderTest).
# They do not touch the changed tool/schema packages, and the ArchUnit
checks pass.
cd rmqctl && go test -count=1 ./internal/catalog/...
# ok
cd rmqctl && go run ./internal/catalog/generate \
-input-dir ../server/src/main/resources/tool-catalog/tools \
-output internal/catalog/catalog_gen.go -check
# exit 0 (catalog digest in sync)
Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (fix:)
- [x] Tests added or updated for non-trivial changes, test methods named
...Test
- [ ] New UI text has both Chinese and English entries under web/src/i18n/
- [x] Architecture constraints stay green (mvn test runs the ArchUnit checks)
- [ ] New source files carry the ASF license header (no new source files
added)
- [ ] Documentation touched where behaviour changed (the output schema is
the source of truth)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
