chennaji9 opened a new pull request, #11301: URL: https://github.com/apache/rocketmq/pull/11301
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. --> ### Which Issue(s) This PR Fixes Fixes #11285 ### Brief Description Adds `RequestBuilderTest` (remoting module, JUnit 4 + AssertJ, same package and style as the existing `RpcRequestHeaderTest`), pinning `RequestBuilder`'s currently untested contract: - `RequestCode.PULL_MESSAGE` maps to `PullMessageRequestHeader` through both `buildTopicQueueRequestHeader` (all four overloads) and `buildCommonRpcHeader` (both overloads), - `brokerName`/`topic`/`queueId`/`lo`/`oneway` field propagation across the overloads, including the nullable `Boolean` cases, - unknown request codes (e.g. 999999, -1) are rejected with `UnsupportedOperationException` whose message contains the code. No production code changes. ### How Did You Test This Change? `mvn -B -pl remoting -am -Dtest=RequestBuilderTest -Dsurefire.failIfNoSpecifiedTests=false test` → BUILD SUCCESS, `Tests run: 8, Failures: 0, Errors: 0, Skipped: 0`. (The cast behavior of `buildCommonRpcHeader` was verified empirically before writing assertions — `RpcRequestHeader` is in the `PullMessageRequestHeader` hierarchy, so both overloads are covered by green tests.) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
