unbridled-41 commented on PR #5069: URL: https://github.com/apache/rocketmq-dashboard/pull/5069#issuecomment-5929062970
Thanks for the review — the blocking item is fixed in f2a4b658: the case is now `aFramePublishedDuringTheDrainShouldNotOvertakeTheBufferedFramesTest` (`AgentStreamSessionReplayOrderTest.java:56`), matching the `AgentRunRegistryTest` convention; `mvn -o test -Dtest=AgentStreamSessionReplayOrderTest` passes (1/1). On the optional item: agreed the `RecordingEmitter` overlaps `AiRunTestSupport.RecordingSseEmitter`, and per your note I have left it in place for now — the two record at different granularity (raw event set vs. filtered JSON frames) and this case needs to count JSON frames only. If you would still prefer the shared `awaitPayload(String)` helper, happy to do that consolidation as a separate change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
