unbridled-41 commented on PR #5120: URL: https://github.com/apache/rocketmq-dashboard/pull/5120#issuecomment-5929157195
Thanks for the review — both points are settled in 3a8f9d46: 1. **AI-tool duplicate row** — the comment above the `executeWithAudit` call in `sendMessage` now states explicitly that an AI-tool send produces a second `SEND_MESSAGE` row (`ToolAuditFilter` records the invocation itself), and that this is the same pair of rows an Apache AI send already yields today. I kept the parity rather than skipping the service-layer row for tool callers, per your note that the skip would be a separate change. 2. **msgId on the success row** — added the result-aware overload `executeWithAudit(..., Function<T,String> successDetail, Supplier<T> action)`; the plain `Supplier`-only variant now delegates to it with `result -> detail`, so every existing call site keeps its behaviour. The cloud send success row now reads `tag=TagA, key=order-1, msgId=msg-cloud` — the exact format the Apache admin client writes (`RocketMQAdminClientImpl.java:563-564`). The FAILED row keeps the request-only detail (no send result exists), and the comment says so. New case `cloudSendSuccessRowCarriesTheMsgIdLikeTheApacheRowTest` pins the full detail string; verified it fails against the pre-overload code (`expected: "tag=TagA, key=order-1, msgId=msg-cloud" but was: "tag=TagA, key=order-1"`) and passes with it. `MetadataServiceTest` 54/54, `org.apache.rocketmq.studio.instance.topic.*Test` 92/92, checkstyle clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
