The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/topic-update-queue-contract has failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
86ed35791e0935c8bdab365f52401e6d8f37708d / Frun1na 
<[email protected]>
fix(topic): require the queue counts on topic updates

An update DTO without queue counts used to arrive at the broker as 0 and
was then read as "not provided" and refilled from the stored value or the
creation default of 8, so an explicit drain-to-zero submitted by a
non-UI caller was silently dropped.

Settle the ambiguity at the API boundary, as prescribed in the review on
#4581: the update DTO now requires writeQueues/readQueues (still
zero-or-positive, so an explicit 0 passes through and drains the topic),
copies them unconditionally onto the VO, and updateTopic sends the
caller's value as-is. The default-8 substitution stays confined to
creation, and the REST contract in docs/api-spec.md already documents
both counts as required.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/36883744369

With regards,
GitHub Actions via GitBox

Reply via email to