Frun1na commented on PR #4810: URL: https://github.com/apache/rocketmq-dashboard/pull/4810#issuecomment-5936511523
Rebased onto the current head, which includes `b42a6ed1b`, and re-checked every `instanceId` row in sections 5 and 6 against the write-path guard: - 5.8 and 6.5 now document `instanceId` as required; `requireWriteInstance` rejects a blank one with 400 on every topic/group write path, the DTO annotation alone does not show it. - 5.5 and 6.6 gained the required `instanceId` row from `@NotBlank` on `DeleteTopicDTO` / `DeleteConsumerGroupDTO`. - 5.3 and 5.4 now only require `name`, following the DTO annotations (`type` / `clusterId` / `writeQueues` / `readQueues` are optional, queues are `@PositiveOrZero`), and `instanceId` is added as required. - 6.8 mentions the `@Size(max = 100)` cap on `groups`. - 5.8 marks `body` optional, since `SendMessageDTO` has no `@NotBlank` on it; the send example now carries the required `instanceId`. - The remaining rows were re-checked and stay as they were: 5.2 (`instanceId` optional filter), 6.7 (all four fields required) and 6.8 (`instanceId` required, already superseded by the cap note). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
