The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/btl-acl-audit-instance has failed.
Run started by GitHub user btlqql (triggered by btlqql).

Head commit for run:
933549f5f1666ead90d5477dce2e8a870936b919 / btlqql <[email protected]>
fix(acl): audit cloud ACL mutations and carry the instance context

The Tencent branches of 
createRule/updateRule/deleteRule/createUser/updateUser/deleteUser returned 
before the audit call that the Apache path records, and TencentAclService 
records nothing itself, so every ACL mutation on a Tencent instance left no 
audit row; the Apache rows also passed clusterId=null, so none of them could be 
attributed to an instance.

Audit both paths with the same vocabulary: the Tencent branches record after 
the provider call succeeds (role name as the resource identifier, since Tencent 
VOs have no numeric id) and auditRule/auditUser now pass the instanceId as the 
audit cluster context. Provider failures still record nothing.

Tests: createRuleShouldAuditTencentRoleMutationsWithTheRoleName, 
createUserShouldAuditTheTencentRoleNameAndTheInstanceState, 
deleteUserShouldAuditTencentRoleDeletionWithTheInstanceState, 
updateRuleShouldAuditTheInstanceContextForApacheInstances (red on the 
unmodified tree: Tests run: 82, Failures: 4; green after the fix: Tests run: 
82, Failures: 0, Errors: 0).

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/36959529630

With regards,
GitHub Actions via GitBox

Reply via email to