The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/btl-url-userinfo has 
failed.
Run started by GitHub user btlqql (triggered by btlqql).

Head commit for run:
ae39d9b5603ed2e1f37ce50ff4e7e009b42c9731 / btlqql <[email protected]>
fix(common): reject credentials embedded in user-supplied URLs

UrlHostGuard.check validated the scheme, the host and the resolved addresses
but never looked at URI.getUserInfo(), so `http://user:password@host` passed
validation, was persisted with the credential inside it, and was returned by
the reader-visible data source list.

Reject any URL whose user-info is present and non-blank, after the cheap
scheme/host checks and before host resolution, naming the dedicated credential
field the caller should use instead. Clean URLs, private site-local hosts and
loopback-for-local-LLM behaviour are unchanged. LlmConfigService.isValidApiBase
(ops/ai) keeps its own host-only check and is not covered here.

Test: UrlHostGuardUserInfoTest (new) plus one SettingsServiceTest case; 4 new
tests failed before the guard change and the whole selection is green after.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/36961700737

With regards,
GitHub Actions via GitBox

Reply via email to