Loyal-Young opened a new pull request, #5370: URL: https://github.com/apache/rocketmq-dashboard/pull/5370
### Which Issue(s) This PR Fixes - Fixes #5369 ### Brief Description When a Data Sources list request failed after changing filters, the page kept rows and a total from the previous filter. The current failure handler now clears those values only when its request is still current. This prevents unrelated rows and their actions from remaining visible under the selected filter. ### Verification - The new regression fails on the original code: a Prometheus row remains after the Thanos-filtered request fails. - `cd web && node node_modules/vitest/vitest.mjs run src/pages/settings/__tests__/DataSourceTab.test.tsx --pool=threads --maxWorkers=1 --reporter=dot` — 13 tests passed. - `cd web && node node_modules/eslint/bin/eslint.js src/pages/settings/DataSourceTab.tsx src/pages/settings/__tests__/DataSourceTab.test.tsx` — passed. - `cd web && node node_modules/typescript/bin/tsc -p tsconfig.app.json --noEmit --pretty false` — passed. - `git diff --check` — passed. ### AI Assistance AI assistance helped inspect the filter failure path and draft a regression test. I reproduced the failure on the original code, reviewed the small state change, and ran the checks above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
