Loyal-Young opened a new pull request, #5387: URL: https://github.com/apache/rocketmq-dashboard/pull/5387
### Which Issue(s) This PR Fixes - Fixes #5386 ### Brief Description A DLQ resend continues at the backend even if its retry modal is dismissed. The modal now blocks Cancel, close, Escape, and backdrop dismissal while the resend request is pending, with an onCancel guard for events racing the UI update. This keeps the request's completion tied to its visible modal and prevents it from closing a newer group draft. ### Verification - The new regression fails on the original code because Cancel remains enabled after `resendDLQ` starts. - `cd web && node node_modules/vitest/vitest.mjs run src/pages/instance/__tests__/DLQPage.test.tsx --pool=threads --maxWorkers=1 --reporter=dot` — 27 tests passed. - `cd web && node node_modules/eslint/bin/eslint.js src/pages/instance/dlq.tsx src/pages/instance/__tests__/DLQPage.test.tsx` — 0 errors; one pre-existing `react-refresh/only-export-components` warning on `dlq.tsx:62`. - `cd web && node node_modules/typescript/bin/tsc -p tsconfig.app.json --noEmit --pretty false` — passed. - `git diff --check` — passed. ### AI Assistance AI assistance helped trace the retry modal lifecycle and draft the pending-resend regression. I confirmed Cancel was enabled on the original code, reviewed the dismissal guards, and ran the checks above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
