Loyal-Young opened a new pull request, #5360:
URL: https://github.com/apache/rocketmq-dashboard/pull/5360

   ### Which Issue(s) This PR Fixes
   
   - Fixes #5358
   
   ### Brief Description
   
   The Message Explorer saved a custom trace topic by instance ID alone. A 
second account using the same browser and instance inherited that topic and 
could silently query the wrong trace topic.
   
   Scope the browser preference by account and instance. Remount the message 
page's state when the signed-in account changes so the previous account's topic 
cannot be written into the new account's key. Anonymous local mode has its own 
scope. Existing unscoped entries are ignored because their owner cannot be 
determined.
   
   ### Verification
   
   - `cd web && node node_modules/vitest/vitest.mjs run 
src/utils/messageTraceTopicStorage.test.ts 
src/pages/instance/__tests__/MessagePageAsyncState.test.tsx --pool=threads 
--maxWorkers=1 --reporter=dot` — 28 tests passed.
   - `cd web && node node_modules/eslint/bin/eslint.js 
src/utils/messageTraceTopicStorage.ts 
src/utils/messageTraceTopicStorage.test.ts src/pages/instance/message.tsx 
src/pages/instance/__tests__/MessagePageAsyncState.test.tsx` — passed.
   - `cd web && node node_modules/typescript/bin/tsc -p tsconfig.app.json 
--noEmit --pretty false` — passed.
   - `git diff --check` — passed.
   
   ### AI Assistance
   
   AI assistance helped trace the storage and React state flow and draft 
regression tests. I reviewed the changed paths and verified the behavior with 
the commands above.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to