chstercc opened a new pull request, #5403:
URL: https://github.com/apache/rocketmq-dashboard/pull/5403
### Which Issue(s) This PR Fixes
- Fixes #5222
### Brief Description
The shared instance selector rendered its placeholder and empty-list hint as
hardcoded Chinese regardless of the display language. Route both through the
translation table:
- placeholder: reuse the existing `common.selectInstance` key (same text,
already
used as a placeholder in `BrokerCluster.tsx`)
- empty-list hint: add `instanceSelect.notFound` (`暂无匹配实例` / `No matching
instances`)
### How Did You Test This Change?
- `cd web && npm test` → 146 files, 1365 tests passed
- `cd web && npm run lint` → 0 errors
- `cd web && npx tsc -b` → clean
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in
- [x] Commit subject follows Conventional Commits (`fix:`)
- [x] Tests added for the change (`InstanceSelect.test.tsx`, 4 cases)
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
- [x] New source files carry the ASF license header
- [x] Architecture constraints stay green (frontend-only change)
- [x] Documentation touched where behaviour changed (N/A)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
