chstercc opened a new pull request, #5415:
URL: https://github.com/apache/rocketmq-dashboard/pull/5415
Which Issue(s) This PR Fixes
None — trivial localization fix.
Brief Description
The metrics explorer's data-source selector had a hardcoded Chinese
aria-label="数据源", so assistive technology announced the Chinese label in the
English UI even though every other label in the component is routed through the
localized copy object. Reuse the existing copy.source key (数据源 / Source).
How Did You Test This Change?
cd web
npx vitest run src/components/__tests__/MetricsExplorer.test.tsx
# → Test Files 1 passed, Tests 35 passed
npm run lint
npm run build
Checklist
One coherent change; unrelated modifications are not bundled in
Commit subject follows Conventional Commits (fix:)
Tests added or updated for non-trivial changes — N/A(trivial 改动,已有测试通过
accessible name 覆盖该 Select)
New UI text has both Chinese and English — 复用已有 copy.source(数据源 / Source)
Architecture constraints stay green — 纯前端改动
New source files carry the ASF license header — 无新增文件
Documentation touched — 无行为变化
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]