The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/aliyun-topic-consumer-unavailable-metrics has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
e7d1d72257f7b401d507024f62bb4e1be87c328f / unbridled-41 
<[email protected]>
fix(aliyun): report topic-consumer lag and TPS as unavailable

GET /api/topics/{name}/consumers on an Aliyun instance returned every
subscribed group with diffTotal = 0 and consumeTps = 0 flagged
metricsAvailable = true, because AliyunConverters.toTopicConsumerVO set
only group/consumeType/messageModel and left the TopicConsumerVO field
defaults (@Builder.Default metricsAvailable = true).

The Aliyun ListTopicSubscriptions response has no lag or TPS field at all -
ListTopicSubscriptionsResponseBody$Data carries consistency,
consumerGroupId, filterExpression, filterExpressionType, messageModel,
subscriptionStatus and topicName - so those zeros were fabricated. The
console renders the number whenever metricsAvailable is not false, and the
AI topic-detail contract exposes the flag, so an operator (or the hosted
agent) reads "0 backlog, 0 TPS" for a group that may be falling behind.

The Apache provider already flags exactly this gap with
metricsAvailable(false) when consume stats cannot be read, and that is the
only value the web table renders as unavailable. Do the same for Aliyun.

Tested: mvn -o test 
-Dtest='AliyunConvertersTest,AliyunInstanceProviderTest,AliyunConvertersLagTest,AliyunConvertersBodyEncodingTest'
-> 60 passed; checkstyle clean.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37086600091

With regards,
GitHub Actions via GitBox

Reply via email to