unbridled-41 opened a new pull request, #5431: URL: https://github.com/apache/rocketmq-dashboard/pull/5431
## Problem / Evidence `deploy/docker-compose.yml` attaches `mysql` and `rocketmq-server` to the externally-declared `rocketmq_net` (`deploy/docker-compose.yml:22-24,95-97,128-130`), but the *local* quickstart in `deploy/README.md` only says to copy `.env` and run compose. On a host that has not created the network, it aborts: ``` $ docker network ls | grep rocketmq_net # absent $ cd deploy && docker compose -f docker-compose.yml up --dry-run --no-start ... network rocketmq_net declared as external, but could not be found ``` The other documented entry points already create it — `deploy/rocketmq/README.md` (stack prerequisite), `deploy/deploy.sh:74`, and the root README's Quick Start, which gained the same idempotent step in #5096. This section was the remaining one without it, so following the local path on a fresh host cannot work. ## Root cause / Fix The prerequisite step was documented everywhere except the studio-only local section. Add it, in the phrasing the root README already uses: ``` docker network inspect rocketmq_net >/dev/null 2>&1 || docker network create rocketmq_net ``` ## Priority & scoring PRIORITY 60 = 影响 20 (the documented one-command local startup fails outright on a fresh host) + 波及 10 (the only studio-only compose entry point) + 可复现 20 (reproduced above with docker 29.1.3 / compose v2.32.4) + 维护价值 10 (aligns the third document with the two that already have the step). FIX_CONFIDENCE 95: one idempotent command, and the result is verified below. ## Tests Documentation change; verified by executing the documented sequence: - Without the network: `docker compose up --dry-run --no-start` → `network rocketmq_net declared as external, but could not be found`. - After the documented `docker network inspect rocketmq_net >/dev/null 2>&1 || docker network create rocketmq_net`: the same dry-run proceeds — `Container rocketmq-server Created`, `Container rocketmq-web Created`. - The temporary `rocketmq_net` was removed afterwards, leaving the host as it was. ## Risk None. One line added to a document; no manifest, compose file or script changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
