unbridled-41 commented on PR #5435: URL: https://github.com/apache/rocketmq-dashboard/pull/5435#issuecomment-5965524131
### Evidence note: the 501 behaviour this section documents is already pinned by tests The five operations this change marks unimplemented are asserted by `ClusterServiceTest`, so the note matches automated coverage rather than only my reading of the service: ``` ClusterServiceTest.java:623 assertUnsupportedOperation(() -> clusterService.createNameServer(command), ...); ClusterServiceTest.java:648 assertUnsupportedOperation(() -> clusterService.updateNameServer(update), ...); ClusterServiceTest.java:650 assertUnsupportedOperation(() -> clusterService.restartNameServer(restart), ...); ClusterServiceTest.java:652 assertUnsupportedOperation(() -> clusterService.upgradeNameServer(upgrade), ...); ClusterServiceTest.java:654 assertUnsupportedOperation(() -> clusterService.deleteNameServer(delete), ...); ``` and the helper asserts the HTTP-`501` mapping (`ClusterServiceTest.java:798-803`: `BusinessException` code `501`). ``` cd server && mvn -o test -Dtest=ClusterServiceTest Tests run: 43, Failures: 0, Errors: 0, Skipped: 0 ``` The registry endpoints the note points readers at are covered by `NameServerController`'s tests. Because the claim was already covered, this PR adds no test of its own — the change is the document only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
