chstercc opened a new pull request, #5488:
URL: https://github.com/apache/rocketmq-dashboard/pull/5488

   <!-- Make sure the base branch is `master`: that is the RocketMQ Studio 
trunk. -->
   
   ### Which Issue(s) This PR Fixes
   
   <!-- Link the issue with a keyword so it closes on merge. Trivial fixes need 
no issue.
        
https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue
 -->
   
   - Fixes #4010
   
   ### Brief Description
   
   <!-- What changes and why. Keep it short — the diff already shows how. -->
   
   Add a dedicated regression test asserting `expect(USE_MOCK).toBe(false)`, 
importing the constant from the real `./config` module.
   
   Preserve all existing API_BASE_URL tests. Only `web/src/config.test.ts` is 
changed; no runtime code, dependencies, lockfiles, or CI changes are included.
   
   This continues #4011, which was closed without being merged.
   
   AI assistance was used for this change. The diff was reviewed and the checks 
below were executed.
   
   ### How Did You Test This Change?
   
   <!-- Paste the commands you ran and what they printed. Typical verification:
        backend  `cd server && mvn -B -ntp test`   (integration tests need 
MySQL 8, see CONTRIBUTING.md)
        frontend `cd web && npm test && npm run lint && npm run build`
        A pull request with no verification will not be merged. -->
   
   In `web`, using Windows command entry points:
   
   - `npm.cmd test -- src/config.test.ts`: 1 test file passed, 4 tests passed; 
exit code 0.
   - `npx.cmd --no-install eslint src/config.test.ts`: no output; exit code 0.
   - `npx.cmd --no-install prettier --check src/config.test.ts`: formatting 
check passed; exit code 0.
   
   At the repository root:
   
   - `git diff --check`: exit code 0; Git emitted an LF-to-CRLF notice.
   - `git diff --name-only upstream/master..HEAD`: only 
`web/src/config.test.ts`.
   
   The pre-commit ESLint and Prettier checks passed. Full test suites, 
production builds, and backend architecture checks were not run.
   
   UI translations, new source-file license headers, and behavior documentation 
updates are not applicable to this test-only change.
   
   ### Checklist
   
   - [x] One coherent change; unrelated modifications are not bundled in
   - [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / 
`refactor:` / `chore:` / `docs:` / `perf:`)
   - [x] Tests added or updated for non-trivial changes, test methods named 
`...Test`
   - [ ] New UI text has both Chinese and English entries under `web/src/i18n/`
   - [ ] Architecture constraints stay green (`mvn test` runs the ArchUnit 
checks)
   - [ ] New source files carry the ASF license header
   - [ ] Documentation touched where behaviour changed (README / `docs/` / 
in-app help)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to