tju-yxq opened a new pull request, #5495:
URL: https://github.com/apache/rocketmq-dashboard/pull/5495
### Which Issue(s) This PR Fixes
- Fixes #5494
### Brief Description
Extends the instance page's failed-reload discipline (#5414) to the ten
remaining pages where a failed list reload after a
filter/scope/search/pagination change kept the previous query's rows listed
under the new filter:
- **Toast-only catches** (8 pages): consumer groups, topic list, audit feed,
notification deliveries, system alerts, alert rules (plus their selection),
data sources, cloud credentials — the catch now clears rows + total (+
selection) alongside the existing toast.
- **Persistent-error catches** (2 pages): DLQ groups and its detail modal,
message query results — the error banner already explained the failure; the
rows beneath it are now cleared so they can not masquerade as current results.
Racing responses remain guarded by the existing request-id/generation
checks; successful loads are unchanged.
### How Did You Test This Change?
The ten affected suites together on this branch (the two reported failures
in the combined run are resource-contention timeouts at 10-file parallelism;
both files pass standalone):
```
cd web && npm test -- ConsumerPage.test.tsx AuditPage.test.tsx
NotificationDeliveriesPage.test.tsx SystemAlertsPage.test.tsx
DataSourceTab.test.tsx CloudCredentialTab.test.tsx AlertsPage.test.tsx
TopicPage.test.tsx DLQPage.test.tsx MessagePage.test.tsx --run
Test Files 8 passed (10) # 2 timeout flakes; both pass standalone
(verified)
Tests 212 passed (214)
```
Two new regression tests pin the pattern end-to-end: the consumer page (a
non-debounced search — every keystroke reloads, all follow-ups fail) and the
audit page (debounced search) both load rows, then fail the filtered reload and
assert the previous rows leave the table. The other eight pages share the
identical catch-path change, verified by the full-suite pass.
Standalone verification of the two flaky files:
- `TopicPage.test.tsx`: 34 passed
- `ConsumerPage.test.tsx`: 40 passed
```
cd web && npm run lint
✖ 10 problems (0 errors, 10 warnings) # the trunk baseline
```
```
cd web && npx tsc -b --force
(no output — exit 0)
```
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in (one
purpose — the failed-reload discipline — across the ten pages it was missing
from, per the grouping guideline #2107)
- [x] Commit subject follows Conventional Commits
- [x] Tests added or updated for non-trivial changes, test methods named
`...Test`
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
(no new UI text)
- [x] Architecture constraints stay green (`mvn test` runs the ArchUnit
checks) (no Java changes)
- [x] New source files carry the ASF license header (no new source files)
- [ ] Documentation touched where behaviour changed (failure-path correction
only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
