unbridled-41 commented on PR #4561:
URL:
https://github.com/apache/rocketmq-dashboard/pull/4561#issuecomment-5969985272
Both mechanical items were fixed in d561ac2f; the sequencing item is now
settled too.
1. **Cause preserved** — `sendTestMessage` logs the original throwable
before mapping it to `BusinessException`: `log.warn("test notification failed
on channel {}: {}", channel, error.getMessage(), error)`. `BusinessException`
has no cause slot, so this log line is the only place the original stack trace
survives; a bare NPE (`getMessage() == null`) is covered by the same line. The
400/502 assertions are unchanged.
2. **Test renamed** — `messageFailureCarriesTheConfigurationReasonTest`
(dropped the `testXxx` prefix, kept the required `Test` suffix).
3. **Rebased onto current `rocketmq-studio`** — #5077 landed as a460673f, so
I merged the base into this branch (de1ecff0). The only conflict was the append
point in `NotificationOutboxServiceTest`: base's
`messageNamesTheChannelItExercisesTest` and this branch's
`messageFailureCarriesTheConfigurationReasonTest` are both kept. The production
file merged automatically, so #5077's per-channel `TEST_MESSAGE_DESCRIPTIONS`
and this branch's `log.warn` coexist.
Tests at de1ecff0:
- `mvn -Dtest=NotificationOutboxServiceTest test` → `Tests run: 31,
Failures: 0, Errors: 0, Skipped: 0`
- Full `mvn test` under `server/` → `Tests run: 3323, Failures: 0, Errors:
18`; the 18 errors are all MySQL-backed Spring integration tests (`Failed to
load ApplicationContext ... Communications link failure`) that fail the same
way on the base without this merge — no test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
