Wang1rrr opened a new pull request, #5521: URL: https://github.com/apache/rocketmq-dashboard/pull/5521
<!-- Make sure the base branch is `rocketmq-studio`: that is the RocketMQ Studio trunk. --> ### Which Issue(s) This PR Fixes Trivial fix, no issue. This replaces #4933, which the stale bot closed before review and which can no longer be reopened. Its branch had also picked up unrelated commits; this one carries only the Apache change. ### Brief Description `TraceNodeVO.status` goes straight to the AntD `Steps` `status` prop, whose vocabulary is `wait | process | finish | error`. `RocketMQMessageProvider.buildProduceNode`, `buildConsumeNode` and `buildRecallNode` still emit the literal `"failed"` for unsuccessful stages (`RocketMQMessageProvider.java:864, :879, :913` on the current trunk). The trace timeline therefore renders a failed produce, consume or recall stage with the default pending look instead of as failed. The same leak was already fixed for the cloud providers in #4914 (Aliyun) and #4915 (Tencent). This maps the Apache failures to `error` as well. ### How Did You Test This Change? - `cd server && mvn -B -ntp test` on JDK 21 with MySQL 8: 3323 tests, 0 failures. The H2-backed integration tests were re-run without the MySQL URL override and pass. - `RocketMQMessageProviderTest`: 62 tests pass. With the production change reverted, the new `getMessageTraceParsesFailedProduceAsErrorTest` and the updated recall-state assertion fail (2 failures), so both cover the change. ### Checklist - [x] One coherent change; unrelated modifications are not bundled in - [x] Commit subject follows Conventional Commits (`feat:` / `fix:` / `refactor:` / `chore:` / `docs:` / `perf:`) - [x] Tests added or updated for non-trivial changes, test methods named `...Test` - [ ] New UI text has both Chinese and English entries under `web/src/i18n/` (no UI text) - [x] Architecture constraints stay green (`mvn test` runs the ArchUnit checks) - [ ] New source files carry the ASF license header (no new files) - [ ] Documentation touched where behaviour changed (no documented behaviour changes) 🤖 Generated with [Claude Code](https://claude.com/claude-code) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
