tju-yxq opened a new pull request, #5540:
URL: https://github.com/apache/rocketmq-dashboard/pull/5540
### Which Issue(s) This PR Fixes
- Fixes #5539
### Brief Description
Aligns both tables with the per-page selection convention the topic and
consumer group tables already follow:
- **dlq.tsx**: removes the dead `preserveSelectedRowKeys: true` — the page
change already clears the selection and every load prunes it to the current
page, so the flag advertised cross-page selection that the code deliberately
prevents. No behavior change.
- **ConversationListModal.tsx**: clears `selectedRowKeys` when the
pagination page changes, so the batch-delete count and its confirmation no
longer include rows from pages the user cannot see. Mirrors the
`setSelectedRowKeys([])` in the topic and consumer group tables' pagination
`onChange`.
### How Did You Test This Change?
```
cd web && npx vitest run src/pages/instance/__tests__/DLQPage.test.tsx
src/pages/ai/__tests__/AiPage.test.tsx
Test Files 2 passed (2)
Tests 41 passed (41) # DLQPage 26, AiPage 15
cd web && npx eslint src/pages/instance/dlq.tsx
src/pages/ai/components/ConversationListModal.tsx
0 errors (1 pre-existing warning)
cd web && npx tsc --noEmit
(no output — exit 0)
```
### Checklist
- [x] One coherent change; unrelated modifications are not bundled in (one
concern — selection semantics — across the two tables that violate it)
- [x] Commit subject follows Conventional Commits
- [ ] Tests added or updated for non-trivial changes, test methods named
`...Test` (selection-semantics correction; the existing DLQPage and AiPage
suites cover both surfaces)
- [x] New UI text has both Chinese and English entries under `web/src/i18n/`
(no new UI text)
- [x] Architecture constraints stay green (no Java changes)
- [x] New source files carry the ASF license header (no new source files)
- [ ] Documentation touched where behaviour changed (selection count only)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
