zjncs opened a new issue, #5609:
URL: https://github.com/apache/rocketmq-dashboard/issues/5609

   ## Description
   
   The console's consumer-group create modal 
(`web/src/pages/instance/consumer.tsx:2441-2452`) offers an order-type select 
when the subscription type is FIFO, posting `deliveryOrderType` values 
`PARTITON_ORDER` / `MESSAGES_ORDER` (the CSV import at 
`web/src/utils/resourceCsvImport.ts:75` also accepts `PARTITION_ORDER`). 
`CreateConsumerGroupDTO` passes the string through untouched.
   
   But `AliyunInstanceProvider.normalizeDeliveryOrderType` 
(`AliyunInstanceProvider.java:381-390`) — whose javadoc promises to "tolerate 
FIFO/ordered spellings from the UI" — only recognizes the literal spellings 
`FIFO`/`ORDERLY`. Every UI spelling (`PARTITON_ORDER`, `MESSAGES_ORDER`, 
`PARTITION_ORDER`) falls through to `"Concurrently"`, and `createConsumerGroup` 
(line 355) then selects `DefaultRetryPolicy` instead of the fixed-interval 
policy ordered groups require:
   
   ```java
   String value = raw.trim();
   if ("FIFO".equalsIgnoreCase(value) || "ORDERLY".equalsIgnoreCase(value)) {
       return ORDERLY_DELIVERY_ORDER_TYPE;
   }
   return DEFAULT_DELIVERY_ORDER_TYPE;   // PARTITON_ORDER lands here
   ```
   
   Failing test on master:
   
   ```
   org.opentest4j.AssertionFailedError: expected: <Orderly> but was: 
<Concurrently>
   ```
   
   The Tencent provider is unaffected (`isOrderly` matches `*ORDER*`), and the 
Apache provider treats the field as metadata only — this is Aliyun-specific.
   
   ## Impact
   
   On Aliyun instances, **every ordered-group creation from the console creates 
a Concurrently group** — the operator's order-type selection is silently 
discarded, ordered consumption semantics are lost, and the retry policy is 
wrong for the intended group type. CSV group imports with `PARTITION_ORDER` are 
dropped the same way.
   
   ## Expected behavior
   
   `normalizeDeliveryOrderType` should recognize the spellings the console 
actually sends — matching the Tencent provider's `ORDER` substring convention 
plus `FIFO`.
   
   ## Environment
   
   - branch: master (0228dad5)
   - file: 
`server/src/main/java/org/apache/rocketmq/studio/provider/alibaba/AliyunInstanceProvider.java`
 (normalizeDeliveryOrderType, ~381-390)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to