zjncs opened a new pull request, #5632: URL: https://github.com/apache/rocketmq-dashboard/pull/5632
Closes #5631 ## Problem The `renders invalid message timestamps as unavailable without throwing` test asserted only the `formatDateTime` **helper** directly and never rendered `DLQPage` — yet the page routes its API values through the helper at three sites (the row's 最近入队时间 column at `dlq.tsx:508`, `:592`, and the detail's last enqueue time at `:885`). A page-level regression — the column bypassing the guard — passed the test untouched. **Discriminating proof**: replacing the column's `formatDateTime(time)` with `String(time)` (helper left intact) leaves the old test **green** — it had zero covering power over the page path. ## Fix (test-only) Keep the helper assertions and additionally render a group whose `lastEnqueueTime` is a non-numeric string (`'not-a-date'`), asserting the row renders `-` through the page's real rendering path. ## Verification - Full `DLQPage` suite: **21/21** with the strengthened test - **Discriminating mutation**: with the row column's `formatDateTime(time)` replaced by `String(time)`, the strengthened test **FAILS** (the row renders `not-a-date` instead of `-`); restored, it passes — the exact regression class the old version could not see - `tsc --noEmit` clean ## Collision note The file is touched by 8 open PRs but their hunks sit at @@206/@579/@684/@695/@896+ — the changed test (~158-175) is region-disjoint. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
