zjncs opened a new pull request, #5736:
URL: https://github.com/apache/rocketmq-dashboard/pull/5736
### What
`ResumeRecovery` — the recognition of the one failure mode a retry can fix,
the session the conversation remembers no longer existing on disk — had no
test. This adds `ResumeRecoveryTest` with 7 tests.
### What is pinned
- a zero exit is never a lost resume, even with the error subtype on the
result frame;
- the `error_during_execution` result subtype **alone** carries the signal,
and so does the CLI's session-not-found stderr line **alone** — both are
checked because either alone is fragile (the stderr text may be reworded by a
CLI upgrade; the subtype is also used for unrelated failures);
- the stderr line must be the **first non-blank content**: a later log line
mentioning the phrase is not the CLI's verdict;
- leading whitespace before the line is tolerated;
- an unrelated failure is not a lost resume;
- **the retry applies only to a run that actually passed `--resume`**:
retrying a fresh run just repeats it;
- the wire constants (the `RESUME_LOST_CODE` error code, the stderr prefix,
the subtype) are stable.
### Verification
- New tests on unmodified code: **7/7 green**, checkstyle clean (`mvn test
-Dtest=ResumeRecoveryTest`).
- Discriminating mutations on `ResumeRecovery`, build result verified red
each time:
1. the zero-exit guard dropped — red;
2. the `resumeRequested` gate dropped from `shouldRetryWithoutResume` —
red;
3. the anchored prefix match relaxed to `contains` — red.
- Restored: 7/7 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
