zjncs opened a new pull request, #5744:
URL: https://github.com/apache/rocketmq-dashboard/pull/5744
### What
`AclMutationInput` — the tool-side ACL rule shape — had no test. This adds
`AclMutationInputTest` with 4 tests.
### What is pinned
- `toRule` maps every field and **takes the numeric id from the caller** —
the tool world speaks string ids (they arrive from the model and the catalog),
the storage world a Long, and the mapping is exact in both directions;
- `from` translates the stored numeric id into the tool-world string;
- an unsaved rule has no id in either world;
- the round trip preserves every mutation field.
### Verification
- New tests on unmodified code: **4/4 green**, checkstyle clean (`mvn test
-Dtest=AclMutationInputTest`).
- Discriminating mutations on `AclMutationInput`, build result verified red
each time:
1. the id translation dropped from `from()` so updates can never find
their row — red;
2. the actions dropped from `toRule` so a mutation loses its permission
list — red;
3. `toRule` ignoring the caller's ruleId so every update lands on a null
id — red.
- Restored: 4/4 green. Test-only change; no product code touched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
